Skip to content

feat: asyncify pickers#709

Merged
tjdevries merged 18 commits intomasterfrom
use_plenary_async
Apr 8, 2021
Merged

feat: asyncify pickers#709
tjdevries merged 18 commits intomasterfrom
use_plenary_async

Conversation

@tjdevries
Copy link
Copy Markdown
Member

@tjdevries tjdevries commented Apr 1, 2021

Working on making pickers async. Will clean up code as I go.

@oberblastmeister oberblastmeister mentioned this pull request Apr 2, 2021
Closed
@oberblastmeister
Copy link
Copy Markdown
Contributor

oberblastmeister commented Apr 2, 2021

I am getting this error for the autocommands finder:

Error executing vim.schedule lua callback: ...scope.nvim/lua/telescope/previewers/buffer_previewer.lua:562: attempt to index field 'finde
r' (a function value)

@Conni2461 Conni2461 mentioned this pull request Apr 3, 2021
Closed
@ThePrimeagen
Copy link
Copy Markdown
Contributor

ThePrimeagen commented Apr 5, 2021

As a consumer of this library and an active watcher of such pull requests, I feel that the founder and main contributor to Telescope having linting issues really reduces my confidence in this project.

@tjdevries
Copy link
Copy Markdown
Member Author

tjdevries commented Apr 5, 2021

Please don't make me turn my profile picture into the leaked photos that have been going around on twitter...

@elianiva elianiva mentioned this pull request Apr 5, 2021
Closed
@tjdevries tjdevries force-pushed the use_plenary_async branch from 8fef77f to da8ea7f Compare April 6, 2021 16:31
@elianiva
Copy link
Copy Markdown
Member

elianiva commented Apr 6, 2021

I've tried it out, this is more than just "works for me", but "works great for me" :D

@tjdevries tjdevries force-pushed the use_plenary_async branch from 1377962 to 0e110b5 Compare April 7, 2021 20:25
@tjdevries tjdevries force-pushed the use_plenary_async branch from 0e110b5 to d9bbeee Compare April 8, 2021 00:43
@tjdevries
Copy link
Copy Markdown
Member Author

tjdevries commented Apr 8, 2021

OK, I think I'm ready to merge this.

Could I get some code review / thoughts / anything? I'll wait 24 hours and then merge (so I can fix on Friday on stream if we have any problems)

@kuator
Copy link
Copy Markdown

kuator commented Apr 8, 2021

OK, I think I'm ready to merge this.

Could I get some code review / thoughts / anything? I'll wait 24 hours and then merge (so I can fix on Friday on stream if we have any problems)

Well to be perfectly honest, in my humble opinion, of course without offending anyone who thinks differently from my point of view, but also by looking into this matter in a different perspective and without being condemning of one's view's and by trying to make it objectified, and by considering each and every one's valid opinion, I honestly believe that I completely forgot what I was going to say

elianiva
elianiva reviewed Apr 8, 2021
View reviewed changes
Comment thread lua/telescope/finders.lua Outdated
fdschmidt93
fdschmidt93 reviewed Apr 8, 2021
View reviewed changes
Comment thread lua/telescope/sorters.lua Outdated
kkharji
kkharji approved these changes Apr 8, 2021
View reviewed changes
Comment thread lua/telescope/finders/async_job_finder.lua
Comment thread lua/telescope/finders/async_job_finder.lua
@tjdevries tjdevries merged commit 64e5906 into master Apr 8, 2021
@dagadbm
Copy link
Copy Markdown

dagadbm commented Apr 8, 2021

just tested this.
NOW i can use telescope :D only think missing is the optional preview, or at least a better visual feedback that the preview is loading

@mherna mherna mentioned this pull request Apr 10, 2021
Closed
williamboman added a commit to williamboman/telescope.nvim that referenced this pull request Apr 14, 2021
@williamboman
Merge remote-tracking branch 'upstream/master' into fix-multiple-clients
22f0879 
* upstream/master:
  picker(live_grep): add option to grep only over open files (nvim-telescope#666)
  git(action): create and checkout branch (nvim-telescope#755)
  readme: fix broken links and spelling errors (nvim-telescope#753)
  added a new DynamicFinder (which can be used with rust_analyzer) (nvim-telescope#705)
  feat: add icons to git_status finder (nvim-telescope#401)
  fix: update to newer code (nvim-telescope#744)
  pickers(buffers): added only_cwd opt (nvim-telescope#739)
  feat: asyncify pickers - except for live_grep (nvim-telescope#709)
  fix: Use standardized names for current buffer fuzzy find (nvim-telescope#737)
  fix(git_branches): use the quoted fields instead of json-formatting and fix regressions with nvim-telescope#695 (nvim-telescope#704)
  feat: buf highlights for current buffer fuzzy find (nvim-telescope#732)
@Conni2461 Conni2461 mentioned this pull request Apr 19, 2021
Closed
@Conni2461 Conni2461 mentioned this pull request May 16, 2021
Closed
@clason clason deleted the use_plenary_async branch August 13, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdschmidt93 fdschmidt93 fdschmidt93 left review comments

@elianiva elianiva elianiva left review comments

@kkharji kkharji kkharji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tjdevries @oberblastmeister @ThePrimeagen @elianiva @kuator @dagadbm @fdschmidt93 @kkharji
⚡